Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CassandraSinkCluster fix lost messages #1845

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 26, 2024

closes #1843

On my local machine:

  • the problem reproduces itself within 10 runs of the test.
  • with this PR, the test ran 100 times without reproducing the issue

I dont think this issue is common enough to rush out a release for, but this intermittent failure did turn out to be a real issue.

@rukai rukai force-pushed the cassandra_sink_cluster_fix_lost_messages branch from 1d2b9b1 to 799789b Compare November 26, 2024 02:56
@rukai rukai force-pushed the cassandra_sink_cluster_fix_lost_messages branch from 799789b to 38817c5 Compare November 26, 2024 02:56
Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #1845 will not alter performance

Comparing rukai:cassandra_sink_cluster_fix_lost_messages (a3eedcb) with main (5ed7a70)

Summary

✅ 38 untouched benchmarks

@rukai rukai marked this pull request as ready for review November 26, 2024 03:39
@rukai rukai force-pushed the cassandra_sink_cluster_fix_lost_messages branch from 0e3c6ac to a3eedcb Compare November 26, 2024 22:58
@rukai rukai merged commit 95c920f into shotover:main Nov 27, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CassandraSinkCluster lost messages
3 participants